Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include global Git ignore file and .git/info/exclude in pants_ignore to ignore for file watching #18649

Merged
merged 11 commits into from
Apr 3, 2023
Merged

Include global Git ignore file and .git/info/exclude in pants_ignore to ignore for file watching #18649

merged 11 commits into from
Apr 3, 2023

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented Apr 1, 2023 •
edited
Loading

Closes #15935.

@Eric-Arellano Eric-Arellano requested review from stuhood and tdyas April 1, 2023 19:08
Eric-Arellano
Eric-Arellano commented Apr 1, 2023
View reviewed changes
Copy link
Contributor Author

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each commit is distinct

@Eric-Arellano Eric-Arellano mentioned this pull request Apr 1, 2023
Closed
@Eric-Arellano
Copy link
Contributor Author

Should we fork the ignore crate in the meantime? I'm optimistic BurntSushi/ripgrep#2482 will be accepted, so it would hopefully be a short-lived fork.

@Eric-Arellano Eric-Arellano mentioned this pull request Apr 1, 2023
Closed
@cognifloyd
Copy link
Member

Go for it. Fork it into the pants org, include the one line change, and then add it to cargo.toml (with a comment specifying linking to the PR so that we can remove the fork later once it's merged/released upstream).

@Eric-Arellano Eric-Arellano changed the title Include .git/info/exclude in pants_ignore to ignore for file watching Include global Git ignore file and .git/info/exclude in pants_ignore to ignore for file watching Apr 1, 2023
cognifloyd
cognifloyd approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand a lot of the rust syntax. But, from what I can tell, this looks great.

I use .git/info/exclude and the global gitignore files, so this change will make things so much nicer for me. Thank you!

stuhood
stuhood approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eric-Arellano Eric-Arellano enabled auto-merge (squash) April 3, 2023 17:54
@Eric-Arellano Eric-Arellano merged commit e7c6e5d into pantsbuild:main Apr 3, 2023
@Eric-Arellano Eric-Arellano deleted the gitignore-global-files branch April 3, 2023 22:02
@stuhood stuhood mentioned this pull request Apr 25, 2023
Closed
@stuhood stuhood mentioned this pull request Sep 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@cognifloyd cognifloyd cognifloyd approved these changes

@tdyas tdyas Awaiting requested review from tdyas

Assignees
No one assigned
Labels
category:new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support other top-level gitignore locations
3 participants
@Eric-Arellano @cognifloyd @stuhood