Bump default version of shfmt from 3.2.4 to 3.6.0 #17777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
changed the title
Eric-Arellano
commented
Dec 12, 2022
Comment on lines
23
to
26
| "v3.2.4|macos_arm64 |e70fc42e69debe3e400347d4f918630cdf4bf2537277d672bbc43490387508ec|2998546", | ||
| "v3.2.4|macos_x86_64|43a0461a1b54070ddc04fbbf1b78f7861ee39a65a61f5466d15a39c4aba4f917|2980208", | ||
| "v3.2.4|linux_arm64 |6474d9cc08a1c9fe2ef4be7a004951998e3067d46cf55a011ddd5ff7bfab3de6|2752512", | ||
| "v3.2.4|linux_x86_64|3f5a47f8fec27fae3e06d611559a2063f5d27e4b9501171dde9959b8c60a3538|2797568", |
There was a problem hiding this comment.
I'm thinking it'd be good for us to start keeping the old default versions around in this option -- it makes it easier for users to simply change [tool].version to keep the same version as a prior Pants release.
The only downsides are these 4 extra lines in our code + longer reference docs because the option's default value will be longer. Seems reasonable.
cc @jriddy - thoughts?
There was a problem hiding this comment.
Makes sense to me. We can special-case this in the reference docs so we show just the first few lines and then an ellipsis.
|
Sounds good to me. Seems like a minor downside
…On Mon, Dec 12, 2022 at 09:52 Eric Arellano ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/python/pants/backend/shell/lint/shfmt/subsystem.py
<#17777 (comment)>:
> "v3.2.4|macos_arm64 |e70fc42e69debe3e400347d4f918630cdf4bf2537277d672bbc43490387508ec|2998546",
"v3.2.4|macos_x86_64|43a0461a1b54070ddc04fbbf1b78f7861ee39a65a61f5466d15a39c4aba4f917|2980208",
"v3.2.4|linux_arm64 |6474d9cc08a1c9fe2ef4be7a004951998e3067d46cf55a011ddd5ff7bfab3de6|2752512",
"v3.2.4|linux_x86_64|3f5a47f8fec27fae3e06d611559a2063f5d27e4b9501171dde9959b8c60a3538|2797568",
I'm thinking it'd be good for us to start keeping the old default versions
around in this option -- it makes it easier for users to simply change
[tool].version to keep the same version as a prior Pants release.
The only downsides are these 4 extra lines in our code + longer reference
docs because the option's default value will be longer. Seems reasonable.
cc @jriddy <https://github.com/jriddy> - thoughts?
—
Reply to this email directly, view it on GitHub
<#17777 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5UH42O6PYVJPHAYEMDLTWM43ZTANCNFSM6AAAAAAS4A6VLA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Bump on approving |
benjyw
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.