Deprecate implicit setting of --remote-cache-{read,write,eager-fetch} with --remote-execution
#15900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e}`, and temporarily deprecate enabling eager_fetch. [ci skip-build-wheels]
tdyas
approved these changes
Jun 22, 2022
| """ | ||
| `--remote-execution` cannot be set at the same time as either | ||
| `--remote-cache-read` or `--remote-cache-write`. | ||
| # TODO: When this deprecation triggers, the relevant TODO(s) in `context.rs` should be |
There was a problem hiding this comment.
Should all of these TODOs be tagged with the same issue number to make finding them easier in the future?
There was a problem hiding this comment.
Mm, whoops: this was set to auto-merge. Yes, possibly. But blame should point to this PR fairly easily (which was why I made it a bi-directional reference).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15854 moved to using the
remote_cacherunner wrapped around theremoterunner. That opened the door to using different values of various--remote-cachesettings, but to preserve existing behavior, we implicitly enabled those settings with remote execution.This change deprecates the implicit settings, asking that users set the previous defaults manually.
[ci skip-build-wheels]