[internal] Hook up check to Go

[Eric-Arellano]

This lets you compile a package without needing to run tests or package a binary.

Note that you can only directly compile a first-party package - to check if a third-party package is buildable, it must be a dependency of a first-party package. Works around #13175.

This does not yet have an optimal UX. It's overly chatty:

❯ ./pants check testprojects/src/go::
13:36:38.57 [INFO] Initializing scheduler...
13:36:39.20 [INFO] Scheduler initialized.
13:36:39.71 [ERROR] Completed: pants.backend.go.goals.check.check_go - go failed (exit code 1).
Partition #1 - github.com/pantsbuild/pants/testprojects/src/go/pants_test:
./testprojects/src/go/pants_test/foo.go:3:1: syntax error: non-declaration statement outside function body

Partition #2 - github.com/pantsbuild/pants/testprojects/src/go/pants_test/bar:



𐄂 go failed.

We also should be streaming the result of each compilation as it happens, which has an added benefit of that output happening when compilation happens as a side effect of run, package, and test. Those fixes will be in a followup.

[ci skip-rust]
[ci skip-build-wheels]

[stuhood]

We also should be streaming the result of each compilation as it happens, which has an added benefit of that output happening when compilation happens as a side effect of run, package, and test. Those fixes will be in a followup.

Not a blocker, but if you do end up making changes here, this is pretty easy to do... mostly just adding def message and def level methods to FallibleBuiltGoPackage.

[stuhood]

This would probably represent a fatal error, right? i.e., something that would prevent anything from compiling? If so, probably fine for it not to be fallible.

[Eric-Arellano]

See #13334. We run go list to determine how to build a package, and also its decencies for inference etc. It's important that syntax errors there don't break the entire build.

[stuhood]

In Python, I think that we skip inference in that case, and the effect is that whichever tool you were attempting to use will fail with the parse error instead (I just observed this with mypy reporting a parse error, which after fixing allowed inference to get further). But yea, either way.

[Eric-Arellano]

Exactly. That PR has the same effect. We give up on inference if we fail to run go list