[internal] Structure sharing for CoarsenedTargets
#13087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
benjyw
approved these changes
Oct 4, 2021
Eric-Arellano
approved these changes
Oct 4, 2021
Comment on lines
+180
to
+181
| # If the component has no sources, it is acting as an alias for its dependencies: return | ||
| # their merged classpaths. |
There was a problem hiding this comment.
What does this represent? An explicit dep on a java_sources target generator?
There was a problem hiding this comment.
Any target type with no matching sources: so yea, java_sources, lockfile targets, etc.
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Oct 5, 2021
Profiles in example Java repositories showed (unsurprisingly) that recursively re-computing `CoarsenedTargets` (each of which did a transitive walk, and then discarded all but the `CoarsenedTarget`s for the input root) was a bottleneck. Unlike `Targets`, `CoarsenedTargets` are by definition acyclic, and so can share structure. This change converts `CoarsenedTarget` to a transitive DAG, and `CoarsenedTargets` to containing only the roots of the walk. Computing `CoarsenedTargets` no longer dominates compilation in example repos. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiles in example Java repositories showed (unsurprisingly) that recursively re-computing
CoarsenedTargets(each of which did a transitive walk, and then discarded all but theCoarsenedTargets for the input root) was a bottleneck.Unlike
Targets,CoarsenedTargetsare by definition acyclic, and so can share structure. This change convertsCoarsenedTargetto a transitive DAG, andCoarsenedTargetsto containing only the roots of the walk.Computing
CoarsenedTargetsno longer dominates compilation in example repos.