Prepare the 2.3.0rc1 release. #11607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
jsirois
commented
Feb 26, 2021
|
|
||
| ### Documentation | ||
|
|
||
| * Less chatty plugin resolution logging (Cherry-pick of #11593) ([#11595](https://github.com/pantsbuild/pants/pull/11595)) |
There was a problem hiding this comment.
Awkward to categorize but it seemed worth noting. There's a tiny perf aspect and then the logging. There was precedent for logging level changes below in Documentation.
There was a problem hiding this comment.
Yeah I think documentation works, or feel free to rename the title to be "Avoid resolving plugins if none specified" and put in Performance. the PR does both things.
Eric-Arellano
approved these changes
Feb 26, 2021
|
|
||
| ### Documentation | ||
|
|
||
| * Less chatty plugin resolution logging (Cherry-pick of #11593) ([#11595](https://github.com/pantsbuild/pants/pull/11595)) |
There was a problem hiding this comment.
Yeah I think documentation works, or feel free to rename the title to be "Avoid resolving plugins if none specified" and put in Performance. the PR does both things.
Cool. I'll save trees and CI credits. |
jsirois
added a commit
that referenced
this pull request
Feb 26, 2021
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip-rust]