Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the Pants PEX in --venv mode. #11591

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Feb 23, 2021

This speeds things up:

$ hyperfine --warmup 2 './dist/pants.2.3.0.dev3+gitddc75f42..pex -V' '../pants/dist/pants.2.3.0.dev3+gitddc75f42..pex -V'
Benchmark #1: ./dist/pants.2.3.0.dev3+gitddc75f42..pex -V
  Time (mean ± σ):     636.7 ms ±  23.3 ms    [User: 441.7 ms, System: 35.9 ms]
  Range (min … max):   618.9 ms … 694.6 ms    10 runs

Benchmark #2: ../pants/dist/pants.2.3.0.dev3+gitddc75f42..pex -V
  Time (mean ± σ):      1.170 s ±  0.017 s    [User: 959.8 ms, System: 56.2 ms]
  Range (min … max):    1.155 s …  1.212 s    10 runs

Summary
  './dist/pants.2.3.0.dev3+gitddc75f42..pex -V' ran
    1.84 ± 0.07 times faster than '../pants/dist/pants.2.3.0.dev3+gitddc75f42..pex -V'

[ci skip-rust]

This speeds things up:
```
$ hyperfine --warmup 2 './dist/pants.2.3.0.dev3+gitddc75f42..pex -V' '../pants/dist/pants.2.3.0.dev3+gitddc75f42..pex -V'
Benchmark #1: ./dist/pants.2.3.0.dev3+gitddc75f42..pex -V
  Time (mean ± σ):     636.7 ms ±  23.3 ms    [User: 441.7 ms, System: 35.9 ms]
  Range (min … max):   618.9 ms … 694.6 ms    10 runs

Benchmark #2: ../pants/dist/pants.2.3.0.dev3+gitddc75f42..pex -V
  Time (mean ± σ):      1.170 s ±  0.017 s    [User: 959.8 ms, System: 56.2 ms]
  Range (min … max):    1.155 s …  1.212 s    10 runs

Summary
  './dist/pants.2.3.0.dev3+gitddc75f42..pex -V' ran
    1.84 ± 0.07 times faster than '../pants/dist/pants.2.3.0.dev3+gitddc75f42..pex -V'
```

[ci skip-rust]
@jsirois
Copy link
Contributor Author

jsirois commented Feb 23, 2021

I don't think anyone actually uses these, but...

@jsirois jsirois merged commit cb5b327 into pantsbuild:master Feb 23, 2021
@jsirois jsirois deleted the pants.pex/venv branch February 23, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants