Plumb the custom certs file through to Pip (via Pex) #10837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Sep 23, 2020
Comment on lines
+112
to
+113
| # The certs file will typically not be in the repo, so we can't digest it via a PathGlobs. | ||
| # Instead we manually create a FileContent for it. |
There was a problem hiding this comment.
@stuhood bump on our convo about porting PathGlobsAndRoot to the Async API. This is really not great to have Path.read_bytes() in a rule. Fine as a temporary workaround, but I think this shows the need.
We can caution plugin authors about the risks of using it. They're adults.
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pip makes its own network connections, so may need the certs file.
Fortunately Pex already plumbs this through, using the
--certflag.[ci skip-rust]
[ci skip-build-wheels]