Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow or remove the hole that pantsd punches in the ignore patterns for .pids #9758

Closed
stuhood opened this issue May 13, 2020 · 0 comments · Fixed by #9773
Closed

Narrow or remove the hole that pantsd punches in the ignore patterns for .pids #9758

stuhood opened this issue May 13, 2020 · 0 comments · Fixed by #9773
Assignees
@stuhood
Labels
bug

Comments

@stuhood
Copy link
Member

stuhood commented May 13, 2020

In #9636, we punched a hole in the ignore patterns in order to allow pantsd to watch its own pidfile. But in cases where users had previously used pantsd, this resulted in a failure to deal with an orphaned watchman socket file (watchman is now disabled by default, so this only impacts users who) which had previous been ignored.

22:32:58:201 [ERROR] 1 Exception encountered:
  Exception: Failed to scan directory "$workspace/.pids/watchman": Expected File, Dir or Link, but ".pids/watchman/watchman.sock" (relative to "$workspace") was a FileType(FileType { mode: 49152 })

Narrowing the pattern to just the .pids/pantsd subdirectory is challenging (possibly not an option) because gitignore patterns do not allow re-including the children (.pids/pantsd in this case) of ignored parents (.pids, due to .*).
@stuhood stuhood self-assigned this May 13, 2020
@stuhood stuhood added this to the 1.28.x milestone May 14, 2020
@stuhood stuhood mentioned this issue May 14, 2020
Merged
stuhood added a commit that referenced this issue May 15, 2020
@stuhood
Further refine the "include .pids" hack. (#9773)
742e334 
### Problem

As described in #9758, there is a workaround in place to allow `pantsd` to watch its pid file in a way that is easily exposed to the Python `pantsd` services. But users who used `pantsd` before we disabled `watchman` will have a socket file at `.pids/watchman/watchman.sock` which needs to continue to be ignored.

### Solution

Refine the workaround to ensure that that subdirectory continues to be hidden. Once less `pantsd` code is on the python side of the FFI boundary we'll have more flexibility to fix this.

### Result

Fixes #9758.

[ci skip-rust-tests]
[ci skip-jvm-tests]
stuhood added a commit that referenced this issue May 15, 2020
@stuhood
Further refine the "include .pids" hack. (#9773)
cafd9db 
### Problem

As described in #9758, there is a workaround in place to allow `pantsd` to watch its pid file in a way that is easily exposed to the Python `pantsd` services. But users who used `pantsd` before we disabled `watchman` will have a socket file at `.pids/watchman/watchman.sock` which needs to continue to be ignored.

### Solution

Refine the workaround to ensure that that subdirectory continues to be hidden. Once less `pantsd` code is on the python side of the FFI boundary we'll have more flexibility to fix this.

### Result

Fixes #9758.

[ci skip-rust-tests]
[ci skip-jvm-tests]
@Eric-Arellano Eric-Arellano removed this from the 1.28.x milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuhood stuhood

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine the workaround that allows pantsd to watch its pid file stuhood/pants
2 participants
@stuhood @Eric-Arellano