Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pantsd] Integration tests under chroot are broken with pantsd #8710

Closed
blorente opened this issue Nov 26, 2019 · 0 comments · Fixed by #9714
Closed

[pantsd] Integration tests under chroot are broken with pantsd #8710

blorente opened this issue Nov 26, 2019 · 0 comments · Fixed by #9714

Comments

@blorente
Copy link
Contributor

Problem

In CI, we run a cron job every day to check that master runs. In that cron job, we run the same integration test shards with and without pantsd.
Since we started introducing integration tests under chroot, those shards have been broken.
The main problem seems to be that Watchman behaves baldly under chroot (relevant thread).
As far as we know, these are the concrete problems:

  • When using with chroot, the watchman socket path ends up being too long.
  • When using with chroot, the folder we chroot to seems to dissapear before we properly close out pantsd, crashing watchman.

Repro

Run integration tests with the flag --test-pytest-chroot and the environment variable USE_PANTSD_FOR_INTEGRATION_TESTS="true"

stuhood pushed a commit that referenced this issue May 7, 2020
### Problem

Using the notify crate for file invalidation is now feature complete, and so we are using two file watching implementations simultaneously under `pantsd`.

### Solution

Disable watchman by default, and deprecate it. Additionally, remove the implementation of the `experimental` flag from notify. Fixes #8710, fixes #8198, fixes #7375, fixes #5487, fixes #4999, fixes #3479.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant