Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider factoring up shared partitioning & caching/invalidation code from JUnitRun and PytestRun #5307

Closed
jsirois opened this issue Jan 10, 2018 · 0 comments
Closed

Consider factoring up shared partitioning & caching/invalidation code from JUnitRun and PytestRun #5307

jsirois opened this issue Jan 10, 2018 · 0 comments
Assignees
@jsirois

Comments

@jsirois
Copy link
Contributor

jsirois commented Jan 10, 2018

Right now both of these tasks partition, invalidate & cache and report in very similar manners. Much code could be shared.
@jsirois jsirois mentioned this issue Jan 10, 2018
Merged
@jsirois jsirois self-assigned this Jan 28, 2018
jsirois added a commit to jsirois/pants that referenced this issue Jan 30, 2018
@jsirois
Simplify JUnitRun internals.
21bddc4 
In addition to simplifying some code this helps pull `JUnitRun` into the
same shape as `PytestRun` to allow factoring out their shared and tricky
code supporting `--fast`/`--no-fast` and `--chroot` options.

Work towards pantsbuild#5073 and pantsbuild#5307.
@jsirois jsirois mentioned this issue Jan 30, 2018
Merged
jsirois added a commit to jsirois/pants that referenced this issue Jan 30, 2018
@jsirois
Simplify JUnitRun internals.
b8f8f5c 
In addition to simplifying some code this helps pull `JUnitRun` into the
same shape as `PytestRun` to allow factoring out their shared and tricky
code supporting `--fast`/`--no-fast` and `--chroot` options.

Work towards pantsbuild#5073 and pantsbuild#5307.
jsirois added a commit to jsirois/pants that referenced this issue Feb 1, 2018
@jsirois
Factor up shared test partitioning code.
f0e9259 
This factors the handling of `--fast`/`--no-fast` partitioning as well
as the attendant results summarization and caching and invalidation
handling to a mixin that `PytestRun` and `JUnitRun` share.

Fixes pantsbuild#5307
This was referenced Feb 1, 2018
Closed
Closed
jsirois added a commit to jsirois/pants that referenced this issue Feb 1, 2018
@jsirois
Factor up shared test partitioning code.
6019f43 
This factors the handling of `--fast`/`--no-fast` partitioning as well
as the attendant results summarization and caching and invalidation
handling to a mixin that `PytestRun` and `JUnitRun` share.

Fixes pantsbuild#5307
jsirois added a commit to jsirois/pants that referenced this issue Feb 1, 2018
@jsirois
Simplify JUnitRun internals.
26424b7 
In addition to simplifying some code this helps pull `JUnitRun` into the
same shape as `PytestRun` to allow factoring out their shared and tricky
code supporting `--fast`/`--no-fast` and `--chroot` options.

Work towards pantsbuild#5073 and pantsbuild#5307.
jsirois added a commit to jsirois/pants that referenced this issue Feb 1, 2018
@jsirois
Factor up shared test partitioning code.
23b45af 
This factors the handling of `--fast`/`--no-fast` partitioning as well
as the attendant results summarization and caching and invalidation
handling to a mixin that `PytestRun` and `JUnitRun` share.

Fixes pantsbuild#5307
@jsirois jsirois mentioned this issue Feb 1, 2018
Merged
jsirois added a commit that referenced this issue Feb 1, 2018
@jsirois
Simplify JUnitRun internals. (#5410)
f2b8c21 
In addition to simplifying some code this helps pull `JUnitRun` into the
same shape as `PytestRun` to allow factoring out their shared and tricky
code supporting `--fast`/`--no-fast` and `--chroot` options.

Work towards #5073 and #5307.
jsirois added a commit to jsirois/pants that referenced this issue Feb 1, 2018
@jsirois
Factor up shared test partitioning code.
b31db27 
This factors the handling of `--fast`/`--no-fast` partitioning as well
as the attendant results summarization and caching and invalidation
handling to a mixin that `PytestRun` and `JUnitRun` share.

Fixes pantsbuild#5307
jsirois added a commit that referenced this issue Feb 1, 2018
@jsirois
Factor up shared test partitioning code. (#5416)
a6a98fe 
This factors the handling of `--fast`/`--no-fast` partitioning as well
as the attendant results summarization and caching and invalidation
handling to a mixin that `PytestRun` and `JUnitRun` share.

Fixes #5307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsirois