Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout support for Go tests #13530

Closed
Eric-Arellano opened this issue Nov 8, 2021 · 0 comments · Fixed by #13707
Closed

Add timeout support for Go tests #13530

Eric-Arellano opened this issue Nov 8, 2021 · 0 comments · Fixed by #13707
Assignees
@Eric-Arellano
Labels
backend: Go Go backend-related issues

Comments

@Eric-Arellano
Copy link
Contributor

No description provided.

@Eric-Arellano Eric-Arellano self-assigned this Nov 8, 2021
@Eric-Arellano Eric-Arellano added the backend: Go Go backend-related issues label Nov 8, 2021
@Eric-Arellano Eric-Arellano mentioned this issue Nov 24, 2021
Merged
Eric-Arellano added a commit that referenced this issue Nov 24, 2021
@Eric-Arellano
IntField and FloatField can ban negative numbers and zero (#13705)
2704e3f 
Prework for #13530. 

[ci skip-rust]
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano mentioned this issue Nov 24, 2021
Merged
Eric-Arellano added a commit that referenced this issue Dec 2, 2021
@Eric-Arellano
Add test_timeout fields to go_package (#13707)
54f72e8 
Closes #13530.

Unlike Python, we use Go's native timeout support instead of the engine's. Users could have already set the timeout globally via `[go-test].args`, so we have to special-case that the global args should override the field.

[ci skip-rust]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eric-Arellano Eric-Arellano

Labels
backend: Go Go backend-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test_timeout fields to go_package Eric-Arellano/pants
1 participant
@Eric-Arellano