Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak initialization of the $wp_object_cache global #231

Merged
merged 3 commits into from
Dec 14, 2018
Merged

Tweak initialization of the $wp_object_cache global #231

merged 3 commits into from
Dec 14, 2018

Conversation

partounian
Copy link
Contributor

No description provided.

@danielbachhuber
Copy link
Contributor

How does this fix the issue?

@partounian
Copy link
Contributor Author

The original report stated

It looks like the global $wp_object_cache isn't set, aka its null when LudicrousDB tries to get something from the cache.

And then I copied these lines https://github.com/tillkruss/redis-cache/blob/68781b5b4cbd35c7eb2ca22d2d0db66ae57044fc/includes/object-cache.php#L180 as everything else seemed fine, and now it works for me.

Sorry for shoddy explanation, it just works for me :o

@danielbachhuber danielbachhuber added this to the 0.7.1 milestone Dec 13, 2018
@danielbachhuber danielbachhuber changed the title Fix issue #230 Tweak initialization of the $wp_object_cache global Dec 13, 2018
@danielbachhuber danielbachhuber self-assigned this Dec 13, 2018
@danielbachhuber
Copy link
Contributor

The test failure against WP_VERSION=nightly seems to be because the nightly build ZIP hasn't caught up to the SVN checkout. I'll ship this tomorrow after I get a passing build.

@danielbachhuber danielbachhuber merged commit 778adb9 into pantheon-systems:master Dec 14, 2018
@partounian partounian deleted the patch-1 branch December 14, 2018 15:08
@danielbachhuber
Copy link
Contributor

Just tagged the v0.7.1 release. Thanks again!

@kingkool68
Copy link

Woo thanks for the fix @partounian

Related stuttter/ludicrousdb#62

@partounian
Copy link
Contributor Author

@kingkool68 thanks for the great issue description, I probably wouldn't have gotten it without you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielbachhuber danielbachhuber

Labels
None yet
Projects
None yet
Milestone
0.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@partounian @danielbachhuber @kingkool68