[BUGS-5651] Workaround issue with preUpdate script. #470
Conversation
kporras07
changed the title
| exec("composer --working-dir=$siteDir require --no-update pantheon-systems/quicksilver-pushback"); | ||
|
|
||
| if (Comparator::greaterThanOrEqualTo($version, '9.5.0')) { |
There was a problem hiding this comment.
Would it be okay to just change this in the template projects? What if the platform.php version is already > 8.1.13? What about php_version in pantheon.yml?
There was a problem hiding this comment.
This is just a stopgap solution to allow it to run composer update without downgrading to 9.4.4 (which was happening because 9.5.0 raised PHP requirement to >=8 (or 8.1?)).
Once composer update runs, it will run the preUpdate code and will set the final version as expected.
Would it be okay to just change this in the template projects?
Template project is drupal-composer-managed, not sure if we want to do that, my guess is not.
What if the platform.php version is already > 8.1.13? What about php_version in pantheon.yml?
This made me think: why not running the already existing pre-update-script in drupal-composer-managed? That would be way better. In order to do that, I need https://github.com/pantheon-systems/drupal-composer-managed/pull/14 to be merged into default. I think that's probably the best solution.
There was a problem hiding this comment.
I found this to not be true unless we deploy to pantheon-upstreams which we don't want right now.
So I made a workaround here and it's working now
kporras07
changed the title
No description provided.