Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMS-639] Change drupal-recommended to drupal-composer-managed when referring to upstream #7292

Merged
merged 8 commits into from
May 5, 2022
Merged

[CMS-639] Change drupal-recommended to drupal-composer-managed when referring to upstream #7292

merged 8 commits into from
May 5, 2022

Conversation

jspellman814
Copy link
Contributor

@jspellman814 jspellman814 commented Apr 22, 2022 •
edited by michellecolon-pantheon
Loading

Closes CMS-639

Summary

Updates drupal-recommended references to drupal-composer-managed.

Effect

The following changes are already committed:

  • Contextual search and replace drupal-recommended to drupal-composer-managed when referring to upstream.
  • Contextual search and replace drupal-recommended to drupal-composer-managed when referring to upstream.

Remaining Work and Prerequisites

Dependencies and Timing

  • Hermes PR 3036 is merged
  • Terminus Build Tools PR 451 is merged

Release:

  • After the dependencies above are complete

Post Launch

Do not remove - To be completed by the docs team upon merge:

  • Redirect /docs/old-path/ => /docs/new-path/ (if applicable)
  • Include/exclude pages ^ respectively within docs search service provider (if applicable)
  • For Heroes - add a props post to the discussion board.
  • Remove from the project board

@pantheondocs
Copy link

pantheondocs commented Apr 22, 2022 •
edited
Loading

Lighthouse Audit Results:

Description Live pr-7292 Difference
Performance Score 46 47 1
Best Practice Score 86 86 0
SEO Score 96 96 0
Accessibility Score 98 98 0

Lighthouse Audit Reports:

Preview Environment

@jspellman814 jspellman814 requested a review from kporras07 April 22, 2022 15:25
@jspellman814
Copy link
Contributor Author

@kporras07 Can you review this for accuracy from a technical standpoint? Thank you!

@michellecolon-pantheon michellecolon-pantheon added Source: Pantheor Contribution from within Pantheon, unspecified team Topic: Drupal labels Apr 22, 2022
kporras07
kporras07 requested changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@kporras07 kporras07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments, looks good :)

source/content/guides/drupal-9-commerce.md Outdated Show resolved Hide resolved
source/content/guides/switch-drupal-recommended-upstream.md Outdated
@@ -10,11 +10,11 @@ contributors: [kporras07]
reviewed: "2022-04-03"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide should now support both drupal-project and drupal-recommended as the starting point

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, not sure if we want to preserve/update the title and url. If changing the URL, I'm not sure about the policy for redirects. Maybe a question for docs team.

Copy link
Contributor Author

@jspellman814 jspellman814 Apr 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kporras07 - I've updated this doc in 47c7142 to include both drupal-project and drupal-recommended. Also changed the title to Switch from Drupal 9 to Drupal (Composer Managed) Upstream to accurately reflect the new upstream name.

@pantheon-systems/docs-admins Would it be possible to change the URL of this page from https://pantheon.io/docs/guides/switch-drupal-recommended-upstream to. https://pantheon.io/docs/guides/switch-drupal-composer-managed-upstream, and put a redirect in place for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

source/content/guides/switch-drupal-recommended-upstream.md Outdated Show resolved Hide resolved
@jspellman814 jspellman814 requested a review from kporras07 April 22, 2022 20:29
@jspellman814 jspellman814 marked this pull request as ready for review April 25, 2022 19:30
@jspellman814
Copy link
Contributor Author

We have technical review complete (thanks, Kevin!) and the associated PR approved (though this won't be merged until after DrupalCon). Moving to ready for review.

michellecolon-pantheon
michellecolon-pantheon approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@michellecolon-pantheon michellecolon-pantheon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michellecolon-pantheon
Copy link
Contributor

@jspellman814 - Putting this in Hold for Release, pending #3036 being merged. Please let me know when that's done and we'll continue the process on our side 🙂

@jspellman814
Copy link
Contributor Author

Thanks @michellecolon-pantheon! Is there anything I need to do on my end for the URL change mentioned above?

#7292 (comment)

@michellecolon-pantheon
Copy link
Contributor

@jspellman814 - Nope! As long as we have the before/after, we should be good, but I'll let you know if anything crops up!

greg-1-anderson
greg-1-anderson requested changes May 2, 2022
View reviewed changes
Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run through all of the instructions for the composer conversion docs and make sure that the provided git commands still work after the switch from master to main

@jspellman814 jspellman814 mentioned this pull request May 2, 2022
Merged
@jspellman814
Copy link
Contributor Author

Make sure to run through all of the instructions for the composer conversion docs and make sure that the provided git commands still work after the switch from master to main

@greg-1-anderson I finished running through the docs, and didn't run into any issue with converting my test site. Could you give this another look? Thank you!

greg-1-anderson
greg-1-anderson approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@jspellman814
Copy link
Contributor Author

@michellecolon-pantheon The PRs linked above have been merged. This is ready to launch.

@EdwardAngert
Copy link
Contributor

preview

@michellecolon-pantheon michellecolon-pantheon merged commit 5501594 into main May 5, 2022
@pantheondocs pantheondocs deleted the cms-639-docs branch May 5, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kporras07 kporras07 kporras07 approved these changes

@greg-1-anderson greg-1-anderson greg-1-anderson approved these changes

@michellecolon-pantheon michellecolon-pantheon michellecolon-pantheon approved these changes

Assignees

@michellecolon-pantheon michellecolon-pantheon

Labels
Process: Hold for Release Source: Pantheor Contribution from within Pantheon, unspecified team Topic: Drupal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jspellman814 @pantheondocs @michellecolon-pantheon @EdwardAngert @greg-1-anderson @kporras07