Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed startup #37

Merged
merged 6 commits into from
Jun 19, 2019
Merged

Fixed startup #37

merged 6 commits into from
Jun 19, 2019

Conversation

avivklas
Copy link
Contributor

@avivklas avivklas commented Jun 19, 2019

task

There was a bug in startup message sequence where the first message after TLS was not read, introduced in #34.

@avivklas avivklas requested a review from shirHornstein June 19, 2019 11:22
@@ -41,7 +41,7 @@ func (t *Transport) StartUp() (Message, error) {
return nil, err
}

msg, err = t.Read()
msg, err = t.read()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@aviaoh aviaoh removed the request for review from shirHornstein June 19, 2019 11:32
@aviaoh aviaoh merged commit 4e6369d into panoplyio:master Jun 19, 2019
@avivklas avivklas mentioned this pull request Jun 19, 2019
@avivklas avivklas deleted the fixed-startup branch June 25, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants