Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet shortcuts not working in HTML #117

Closed
davidwarrington opened this issue Oct 7, 2022 · 5 comments
Closed

Emmet shortcuts not working in HTML #117

davidwarrington opened this issue Oct 7, 2022 · 5 comments
Labels
⚡Enhancement New feature or request 🚢 Shipping Next Release This issue has been completed and will be available next release

Comments

@davidwarrington
Copy link
Collaborator

I can't use emmet shortcuts to generate HTML. For example previously I could type .my-element and then press tab to generate

<div class="my-element"></div>

This still works inside .html files so I'm assuming the 3.* update is the cause.

@panoply
Copy link
Owner

panoply commented Oct 7, 2022

You'll need to associate this in workspace:

{
  "emmet.includeLanguages": {
    "liquid": "html"
  }
}

We can infer these settings automatically in the defaults, do you think it would be better to do this?

@panoply panoply added the 💬 Question Further information is requested or insight to be given label Oct 7, 2022
@davidwarrington
Copy link
Collaborator Author

That worked a charm, cheers! It's been such a long time since I've had to do that for anything.

I think it would be sensible to make a default as I'm unaware of any contexts where you'd use Liquid outside of HTML. That being said I don't know how many people actually use emmet abbreviations. If not a default perhaps a note could be added to the extension docs, as I'd guess this won't be the last time you're asked about this.

@panoply
Copy link
Owner

panoply commented Oct 7, 2022

Good point. I'll add it in v3.1.0 to defaults.

panoply added a commit that referenced this issue Oct 7, 2022
@panoply panoply added ⚡Enhancement New feature or request v3.1.0 🚢 Shipping Next Release This issue has been completed and will be available next release and removed 💬 Question Further information is requested or insight to be given labels Oct 7, 2022
@panoply
Copy link
Owner

panoply commented Oct 7, 2022

Alright, co-authored this one and it will be available on the default. Included Liquid CSS and Liquid SCSS snippets. Following extensions will automatically have emmet available:

  • .liquid
  • .css.liquid
  • .scss.liquid

@panoply
Copy link
Owner

panoply commented Oct 25, 2022

Shipped #110

@panoply panoply closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡Enhancement New feature or request 🚢 Shipping Next Release This issue has been completed and will be available next release
Projects
None yet
Development

No branches or pull requests

2 participants