Added failing tests for #151 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2021 14:47
Temporary commit to see if the memory issue is fixed.
|
There's the timeout error: https://github.com/pangeo-forge/pangeo-forge-recipes/pull/220/checks?check_run_id=3795717468#step:8:821 In theory, it should be fixed with 0f9ce09. Then we'll decide how to reconcile this PR and the larger changes in #219 (this will create a merge conflict, so isn't worth merging if #219 will fix it anyway). |
This reverts commit 0f9ce09.
|
So it turns out that my "fix" is faulty. Dask doesn't replace functions in tasks, just arguments, so putting the functions in the task graph once doesn't work. I don't think that #219 suffers from the same problem, since the large objects will be in the context as an argument, rather than the function. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a tests for the memory issues from #151. It should fail on master with a TimeoutError after 90s.
After confirming that it fails I'll push a (temporary) commit with one of the proposed fixes to ensure that it passes.