Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test recipe: fix getLogger and use copy_pruned #37

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

cisaacstern
Copy link
Member

This PR does two things. The first is a fix, which is to get the logger named "pangeo_forge_recipes", because: (a) there actually is no module and/or logger named "pangeo_forge" in the bakery image we are using; and (b) the previous approach which, IIUC, aims to log only for pangeo_forge_recipes.recipes.xarray_zarr, doesn't capture logging from other modules (e.g. storage) which are important for debugging.

The second thing this PR does is register a copy_pruned subset of the recipe object, rather than the full timeseries. This is perhaps a bit more opinionated of a choice. I'm making it because at this stage of testing, IMHO, we don't need to be moving a lot of data around, but rather just ensuring that we can get end-to-end on a single recipe execution cycle. (And this is what the copy_pruned method was designed for: to provide a smaller subset of the recipe for workflow debugging.)

xref #19 (comment)

@cisaacstern
Copy link
Member Author

I think this is somewhat uncontroversial, and falls more so within the Pangeo Forge technical domain (as opposed to the cloud deployment side), so in the interest of moving forward, I'll merge now. We can always adjust later as needed.

@cisaacstern cisaacstern merged commit 52e2297 into main Feb 3, 2022
@cisaacstern cisaacstern deleted the fix-test-logging branch February 3, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant