Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to python 3.12 #556

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Bump to python 3.12 #556

merged 2 commits into from
Jun 24, 2024

Conversation

scottyhq
Copy link
Member

closes #497

Copy link
Contributor

Binder 👈 Try on Mybinder.org!

@pangeo-bot
Copy link
Collaborator

/condalock
Automatically locking new conda environment, building, and testing images...

@@ -45,8 +45,7 @@ aws-c-sdkutils==0.1.16
aws-checksums==0.1.18
aws-crt-cpp==0.26.12
aws-sdk-cpp==1.11.329
awscli==2.17.0
awscrt==0.20.10
awscli==1.32.106
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@weiji14 weiji14 Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that python312 migration for awscli v2 doesn't look very active (upstream situation also looks stuck aws/aws-cli#8342). Do we want to wait for that, or go with this awscli downgrade to v1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think downgrading is fine. i've still yet to see a situation that requires v2 (https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration-changes.html)... As long as aws s3 ls works I'm happy :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't do much fancy stuff either besides aws s3 ls and aws s3 cp 😂. We'll hear soon enough if people have issues (and can let them pin to pangeo-docker-images 2024.06.23😝)

@@ -112,7 +112,8 @@ dependencies:
- xarray_leaflet
- xarray-spatial
- xbatcher
- xcape
# https://github.com/conda-forge/xcape-feedstock/pull/22
#- xcape
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropping b/c blocking both #396 and #497 and doesn't seem very active. people can always install it on top of the default environment

@scottyhq scottyhq requested a review from weiji14 June 24, 2024 02:08
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scottyhq!

@scottyhq scottyhq merged commit b5d9294 into master Jun 24, 2024
5 checks passed
@scottyhq scottyhq deleted the py312 branch June 24, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Images to Python 3.12
3 participants