Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/API: allow get_indexer to work with nans #7855

Closed
wants to merge 1 commit into from
Closed

BUG/API: allow get_indexer to work with nans #7855

wants to merge 1 commit into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 27, 2014

closes #7820

@jreback jreback added this to the 0.15.0 milestone Jul 28, 2014
@jreback
Copy link
Contributor

jreback commented Jul 28, 2014

looks ok conceptually...but failing tests.

@cpcloud
Copy link
Member Author

cpcloud commented Jul 28, 2014

yeah a few kinks to work out

@jreback
Copy link
Contributor

jreback commented Aug 8, 2014

@cpcloud can you circle back to this when you have a chacne?

@cpcloud cpcloud self-assigned this Aug 8, 2014
@cpcloud
Copy link
Member Author

cpcloud commented Aug 8, 2014

sure

@jankatins
Copy link
Contributor

If this is fixed, the workaround in categorical.py should be removed:

        # FIXME: the following can be removed after https://github.com/pydata/pandas/issues/7820
        # is fixed.
        # float levels do currently return -1 for np.nan, even if np.nan is included in the index
        # "repair" this here
        if com.isnull(rvalue).any() and com.isnull(self.levels).any():
            nan_pos = np.where(com.isnull(self.levels))
            lindexer[lindexer == -1] = nan_pos

[This is in #8007, so not yet merged]

@jreback
Copy link
Contributor

jreback commented Sep 8, 2014

@cpcloud ?

1 similar comment
@jreback
Copy link
Contributor

jreback commented Sep 17, 2014

@cpcloud ?

@jreback
Copy link
Contributor

jreback commented Sep 26, 2014

@cpcloud status?

@jreback jreback modified the milestones: 0.15.1, 0.15.0 Sep 29, 2014
@jreback
Copy link
Contributor

jreback commented Jan 18, 2015

@cpcloud can you update?

@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 3, 2015
@jreback
Copy link
Contributor

jreback commented Apr 8, 2015

closing

@jreback jreback closed this Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index([1,2,.np.nan]).get_indexer([np.nan]) returns wrong value?
3 participants