Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: check for __array__ instead of ndarray subclasses when creating an Index #7270

Merged
merged 1 commit into from
May 29, 2014

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented May 29, 2014

This allows custom ndarray-like objects which aren't actual ndarrays
to be smoothly cast to a pandas.Index:
#5460 (comment)

@shoyer
Copy link
Member Author

shoyer commented May 29, 2014

Could someone kindly retrigger the Travis build?

I'm not sure exactly what happened, but I think the failure is spurious: the build passed when Travis ran on the branch in my fork:
https://travis-ci.org/shoyer/pandas/builds/26263713

@jreback
Copy link
Contributor

jreback commented May 29, 2014

rebase on master and push again (this was just fixed in master).

as an aside, you can git commit -C HEAD --amend and force push to resend the build

…an Index

This allows custom ndarray-like objects which aren't actual ndarrays
to be smoothly cast to a pandas.Index:
pandas-dev#5460 (comment)
@shoyer
Copy link
Member Author

shoyer commented May 29, 2014

OK, Travis passed after the rebase.

@jreback
Copy link
Contributor

jreback commented May 29, 2014

gr8. we will need a release note (but 0.14.1 not up yet....check back in 2 days)

@shoyer
Copy link
Member Author

shoyer commented May 29, 2014

No chance I could sneak this in 0.14.0? :)

On Thu, May 29, 2014 at 10:58 AM, jreback [email protected] wrote:

gr8. we will need a release note (but 0.14.1 not up yet....check back in 2
days)


Reply to this email directly or view it on GitHub
#7270 (comment).

@jreback jreback modified the milestones: 0.14.0, 0.14.1 May 29, 2014
@jreback
Copy link
Contributor

jreback commented May 29, 2014

ok no biggie (dont' worry about the release note then)....that's changing (all going to be in whatsnew from now on)

jreback added a commit that referenced this pull request May 29, 2014
ENH: check for __array__ instead of ndarray subclasses when creating an Index
@jreback jreback merged commit f9bcce7 into pandas-dev:master May 29, 2014
@shoyer shoyer deleted the use-__array__ branch June 2, 2014 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants