-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Change truncation ellispsis to unicode character #7167
Conversation
I believe #7174 is fixed. Shall I try to apply the changes to the current master or should we try to merge this enhanced version? http://nbviewer.ipython.org/gist/bjonen/27aaf7d0981c8c1b4d84 |
hmm I suppose if we merge the enhanced version then we should cut a rc2 (no big deal to do it). |
i think we should merge the fix for #7174 then cut the rc |
and leave this for 14.1 |
@bjonen can you split out that fix into a separate PR? |
Sure will do. |
@bjonen can you show |
You are right. Row multiindex needs fixing also. The column fix was easy to extract. I'll submit a PR when the rows are done. |
awesome column fix looks good! |
Rebased with current master and updated notebook (see top). |
from pandas.tools.merge import concat | ||
|
||
self.horiz_ellips = u('\u22ef') # ⋯ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment below, make these package level globals
add an example in v0.14.1.txt (this is now going to be only place, no more release notes) |
@bjonen whenever you can address my comments....like to get this in early this cycle |
@jreback Sure, changed the location of the ellipsis. Example is still missing. I'm dealing with a problem in the console at the moment. While the unicode characters seem to work well in the notebook, I'm having a bit of trouble in the console representation. It seems the unicode characters are not aligning properly. I'll look into this as soon as I have the time. |
I'm having trouble to align the unicode characters well in the console. I'm not sure it might be that they do not take exactly one character length. I can post an example case on the weekend. If this should go in the next release we could just keep it for html for now. |
my 2c. I think that using horizontal dots for both vertical/horizonatl sep is fine. the only enhancement that I think I saw was the using the diagonal dots are cool, but these are unicode so have to be restricted to terminals? (or just html?) |
i think using horizontal dots crowds the display unnecessarily. @bjonen the vert ellipsis is slightly aligned to the right with certain fonts on certain terminals which personally i think is not a problem, and i would say is certainly better than
on github it shows up where you'd think. i suggested the What about having an (experimental?) option (default something like
|
I agree that unicode ellipsis are prettier. However, I find the slight right-alignment in the Ubuntu terminal quite confusing. Making this optional for now sounds good to me. |
closing for now. I think the display is good ATM. |
Changes the truncation symbol from '...' to the math characters horizontal, vertical and diagnol ellipsis as proposed in #7086 (comment).
In the Ipython Notebook, the result looks like this
http://nbviewer.ipython.org/gist/bjonen/492fea9559fd73edf579
To do: