Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/API: info repr should honor display.max_info_columns #7130

Merged
merged 1 commit into from
May 14, 2014

Conversation

TomAugspurger
Copy link
Contributor

Closes #6939

I think this is what we agreed on. The tests are split up. In test_format we do more of the following global settings tests. The rest are in test_frame which directly call df.info() and I'm basically testing that the kwargs there override the global settings.

@jreback jreback added this to the 0.14.0 milestone May 14, 2014
@jreback jreback added Regression and removed Bug labels May 14, 2014
@@ -210,6 +210,11 @@ API changes
# this now raises for arith ops like ``+``, ``*``, etc.
NotImplementedError: operator '*' not implemented for bool dtypes

- The `verbose` keyword in ``DataFrame.info()``, which controls whether to shorten the ``info``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would move this to the display section (right below)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, I wasn't sure whether it was more API or more display.

@TomAugspurger
Copy link
Contributor Author

I guess this only closes half of #6939, There's still the second bullet:

we could add a keyword argument like show_counts (or another name) to specify if you want to show the non-null counts (to be able to override the max_info_rows option for a specific info call)

@jreback
Copy link
Contributor

jreback commented May 14, 2014

let's create a new issue for show_counts and put in 0.14.1

but this IS an API change yes? as max_info_columns took an integer before, and now is boolean/None ?

@TomAugspurger
Copy link
Contributor Author

I didn't change anything with the config. The only API change was to info where now the verbose kwarg take None/True/False.

the max_info_columns is the same as before, but now info actually follows it (unless overridden). I do remember a discussion about what to do with None in this kind of setting, but I don't think it was for this issue.

@jreback
Copy link
Contributor

jreback commented May 14, 2014

@TomAugspurger sorry...you are right....was thinking about something else....ok...gr8 then....

merge when ready / green

(and I would separate out the show_counts option to another issue for later)

@TomAugspurger
Copy link
Contributor Author

Ok. I'll open one up. The test failure was a mistake in the test. Should pass now.

TomAugspurger pushed a commit that referenced this pull request May 14, 2014
BUG/API: info repr should honor display.max_info_columns
@TomAugspurger TomAugspurger merged commit 0912936 into pandas-dev:master May 14, 2014
@jreback
Copy link
Contributor

jreback commented May 14, 2014

excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Output-Formatting __repr__ of pandas objects, to_string Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: regression in max_info_columns behaviour?
2 participants