Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Enforce deprecation of axis=None in DataFrame reductions #57684

Merged
merged 6 commits into from
Mar 5, 2024
Merged

CLN: Enforce deprecation of axis=None in DataFrame reductions #57684

merged 6 commits into from
Mar 5, 2024

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Ref: #52042

@rhshadrach rhshadrach added Clean DataFrame DataFrame data structure Reduction Operations sum, mean, min, max, etc. labels Feb 29, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Feb 29, 2024
@mroeschke
Copy link
Member

Looks good. Just an ASV needs fixing

@rhshadrach
Copy link
Member Author

Thanks @mroeschke - removed the failing benchmark: with axis=None it was now computing std over invalid dtypes.

@mroeschke mroeschke merged commit 654c6dd into pandas-dev:main Mar 5, 2024
46 of 47 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the cln_reduction_axis_none branch March 5, 2024 23:09
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@rhshadrach @pmhatre1
CLN: Enforce deprecation of axis=None in DataFrame reductions (pandas…
b3dd3d5 
…-dev#57684)

* CLN: Enforce deprecation of axis=None in DataFrame reductions

* Remove test

* cleanup

* Skip ASV benchmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Clean DataFrame DataFrame data structure Reduction Operations sum, mean, min, max, etc.
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @mroeschke