-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: Positional arguments in Series.to_markdown #57372
Merged
twoertwein
merged 8 commits into
pandas-dev:main
from
rmhowe425:dev/depr/Series-to-string
Feb 18, 2024
Merged
DEPR: Positional arguments in Series.to_markdown #57372
twoertwein
merged 8 commits into
pandas-dev:main
from
rmhowe425:dev/depr/Series-to-string
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mroeschke Pinging on green |
Looks good to me! If you want to, you can also add overloads that already use the keyword-only syntax: @overload
def to_markdown(
self,
buf: None = ...,
*,
mode: str = ...,
index: bool = ...,
storage_options: StorageOptions | None = ...,
**kwargs,
) -> str: ...
@overload
def to_markdown(
self,
buf: IO[str],
*,
mode: str = ...,
index: bool = ...,
storage_options: StorageOptions | None = ...,
**kwargs,
) -> None: ...
@overload
def to_markdown(
self,
buf: IO[str] | None,
*,
mode: str = ...,
index: bool = ...,
storage_options: StorageOptions | None = ...,
**kwargs,
) -> str | None: ... |
The changes look good to me, but the doc-test is failing (@mroeschke). The doc-test should definitely succeed before merging as the typing tests run after the doc-tests (in case mypy/pyright pick up something). |
twoertwein
reviewed
Feb 18, 2024
twoertwein
approved these changes
Feb 18, 2024
23 tasks
Thank you @rmhowe425 ! |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Updated whatsnew and added deprecation message. * Adding unit test for deprecation warning. * Updating unit tests. * Update series.py * Updating unit test and documentation. * Adding in to_markdown overload functions per reviewer feedback. * Updating implementation based on reviewer feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.