REGR: Fix to_numpy conversion for arrow ea with float dtype given #57233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
This should fix #57093 as well. I started something similar in #57170. Do you want to copy the test from #57170 into this PR and I'll close mine? you might also want to include the |
weikhor
reviewed
Feb 4, 2024
Comment on lines
40
to
46
| elif dtype is not None: | ||
| dtype = np.dtype(dtype) | ||
| if na_value is lib.no_default and hasna and dtype.kind == "f": | ||
| na_value = np.nan | ||
| dtype_given = True | ||
| else: | ||
| dtype_given = True |
There was a problem hiding this comment.
Do you think it is better if we write from two blocks to single block ?
else:
if dtype is not None:
dtype = np.dtype(dtype)
if na_value is lib.no_default and hasna and dtype.kind == "f":
na_value = np.nan
dtype_given = True
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 7, 2024
… ea with float dtype given
|
Does this address #57233 (comment) as well? |
mroeschke
pushed a commit
that referenced
this pull request
Feb 7, 2024
… arrow ea with float dtype given) (#57294) Backport PR #57233: REGR: Fix to_numpy conversion for arrow ea with float dtype given Co-authored-by: Patrick Hoefler <[email protected]>
|
Yikes I missed that comment, will follow up |
5 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.xref #57121