54628 fix find stack level memory leak #57078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-level-memory-leak
WillAyd
approved these changes
Jan 26, 2024
|
Thanks @lmmx for the initial find |
|
Should we backport this for 2.2.x? (it's a memory leak, although presumably only a small one) |
|
Sure no harm in doing so |
|
@meeseeksdev backport 2.2.x |
|
@meeseeksmachine backport 2.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 27, 2024
mroeschke
added a commit
that referenced
this pull request
Jan 27, 2024
… leak) (#57105) Backport PR #57078: 54628 fix find stack level memory leak Co-authored-by: Matthew Roeschke <[email protected]>
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* fix: prevent potential memory leak * test: unit test to cover find_stack_level utility function * style: linting fixes and forgot to rename a funcdef * style: linter fix and forgot to rename a variable in test * test: simplify test and correct value (direct call stack level is 1 not 0) * Add pydoc reference, remove file * Call finally closer to its use --------- Co-authored-by: Louis Maddox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_stack_level#54628 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.