-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Allow to assign/create custom body_style and header_style property to an instance of ExcelFormatter used in method df.to_excel() #53973
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fd851c2
Adding logic for implementation, unit tests, and updated documentation.
rmhowe425 22fe8da
Adding logic for implementation, unit tests, and updated documentation.
rmhowe425 14b8150
Updating implementation and unit tests
rmhowe425 f2a9f53
Updating implementation and unit tests
rmhowe425 12f06cf
Merge branch 'main' into dev/excel-formatter-style
rmhowe425 461c05a
Updating logic and unit tests.
rmhowe425 b09c3e5
Updating implementation to fix CI test.
rmhowe425 255a1bd
Updating implementation to fix CI test.
rmhowe425 161b3f6
Fixing failed unit test.
rmhowe425 646673e
Fixing failed unit test.
rmhowe425 c9bd6c9
Updating implementation based on reviewer feedback.
rmhowe425 5273500
Updating implementation based on reviewer feedback.
rmhowe425 0299e72
Adding additional unit tests and updating documentation.
rmhowe425 af1840c
Merge branch 'main' into dev/excel-formatter-style
rmhowe425 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is doing what you might expect. In particular, this is not using getters/setters, but rather just overwriting a property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhshadrach @attack68
What do we think would be the appropriate implementation for this request then? It seems like the initial suggestion is not ideal.
What do we think about setting the default style to
None
for both header_style and body_style and have users rely on Styler to format output ofto_excel
as mentioned here?