-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: Decouple Series.apply from Series.agg #53400
Merged
rhshadrach
merged 13 commits into
pandas-dev:main
from
topper-123:decouple_Apply.apply_from_Apply.agg
Jun 5, 2023
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
75ce829
REF: Decouple Series.apply from Series.agg
topper-123 52db878
add GH number
topper-123 fc26828
fix docstring
topper-123 4d0db30
Merge branch 'master' into decouple_Apply.apply_from_Apply.agg
topper-123 c521691
update according to comments
topper-123 9353f06
rename array_ops_only -> by_row
topper-123 e7e3433
rename _apply_dict_like -> agg_or_apply_dict_like
topper-123 755ec07
update tests
topper-123 92e7a9f
Merge branch 'master' into decouple_Apply.apply_from_Apply.agg
topper-123 e68c46e
add tests
topper-123 9af24b2
add testr II
topper-123 af0417d
update according to comments
topper-123 8564968
kwds -> kwargs
topper-123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@topper-123: shouldn't by_row here be True for backwards compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, I'm thinking this should now be
self.by_row
when that attribute exists. If a user callsser.apply(["sum", "mean"], by_row=True)
(or withby_row=False
), shouldn't we be passing the argument down to the next call to apply?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right. I'll make a new PR on that.