BUG/TST: Fix Excel writers with duplicated column names. #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _skip_if_no_xlrd() | ||
| ext = self.ext | ||
| path = '__tmp_to_excel_duplicated_columns__.' + ext | ||
|
|
There was a problem hiding this comment.
can you put he issue number here a comment
|
@jreback Added comment with issue number. |
|
gr8....also need a release notes entry.....thanks...then can merge |
|
@jreback Added the following to - Fixed bug in Excel writers where frames with duplicate column names weren't
written correctly. (:issue `5235`)If you wish to reword let me know and I will amend. |
| @@ -611,6 +611,8 @@ Bug Fixes | |||
| the original ordering (:issue:`4621`). | |||
| - Fixed ``Period`` with a business date freq to always roll-forward if on a | |||
| non-business date. (:issue:`5203`) | |||
| - Fixed bug in Excel writers where frames with duplicate column names weren't | |||
| written correctly. (:issue `5235`) | |||
|
@jreback Fixed |
|
gr8 waiting for Travis then will merge |
|
thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test and fix for issue #5235