DEPR: Remove (Int|UInt|Float)64Index #50908
Conversation
| @@ -498,7 +495,7 @@ def __new__( | |||
|
|
|||
| klass = cls._dtype_to_subclass(arr.dtype) | |||
|
|
|||
| # _ensure_array _may_ be unnecessary once Int64Index etc are gone | |||
| # _ensure_array _may_ be unnecessary once NumericIndex etc are gone | |||
There was a problem hiding this comment.
i think changing this misses the point of this comment
There was a problem hiding this comment.
I'm not sure I follow you here, could you expand?
There was a problem hiding this comment.
the comment is suggesting that _ensure_array will become unnecessary
| @@ -119,7 +119,7 @@ def load_reduce(self): | |||
| "TimedeltaIndex", | |||
| ), | |||
| ("pandas.indexes.numeric", "Float64Index"): ( | |||
| "pandas.core.indexes.numeric", | |||
| "pandas.core.indexes.base", | |||
There was a problem hiding this comment.
if these classes dont exist anymore, should we just remove these dict entries?
There was a problem hiding this comment.
These are a lot of other backward-compat stuff here also, and I think there should be a common decision for all of these that are older than some determined release version. For example, remove everything older than v1.0.
I could make a separate issue, where that is discussed?
There was a problem hiding this comment.
I could make a separate issue, where that is discussed?
@jreback any idea? i think this is pickle-related, which i usually punt on
topper-123
force-pushed
the
remove_int64_uint_float64index_final
branch
from
a40308c to
f173216
Compare
|
The remaining failure look unrelated. |
|
Thanks @topper-123 |
* DEPR: Remove (Int|UInt|Float)64Index * fix pre-commit * fix stuff
* DEPR: Remove (Int|UInt|Float)64Index * fix pre-commit * fix stuff
Actually removes
Int64Index,UInt64Index&Float64Index. Also does some cleanups that previous deprecation PRs didn't catch.This PR formally achieves the goals set out in #42717. In real terms there are a few outstanding items, which still need to be addressed:
NumericIndexintoIndexwhatsnewentry for this changepandas/tests/arithmeticcover 8/16/32 bit dtypesSo I'd like to kep #42717 open until those are resolved.