BLD: Add meson build scripts #49114
Merged
BLD: Add meson build scripts #49114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
changed the title
mroeschke
approved these changes
Oct 17, 2022
|
Thanks, just some questions to follow up |
mroeschke
reviewed
Oct 17, 2022
|
|
||
| def write_version_info(path): | ||
| if os.environ.get("MESON_DIST_ROOT"): | ||
| # raise ValueError("dist root is", os.environ.get("MESON_DIST_ROOT")) |
There was a problem hiding this comment.
If you could remove in a follow up that would be great
mroeschke
reviewed
Oct 17, 2022
| import argparse | ||
| import os | ||
|
|
||
| import versioneer |
There was a problem hiding this comment.
So this won't be our vendored versioneer?
There was a problem hiding this comment.
Oops. I forgot to update this when I moved it into scripts, will fix it in my next PR.
Unfortunately, I don't think we are able to use non-vendored versioneer.
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* BLD: Add script to generate pxi from pxi.in for meson * BLD: Add scripts to generate the project version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.In preparation for the rest of the meson build system support.