REGR: Fix nan comparison for same Index object #47326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Missing-data
pandas/core/indexes/base.py
Outdated
| @@ -6955,7 +6955,7 @@ def _cmp_method(self, other, op): | |||
| # TODO: should set MultiIndex._can_hold_na = False? | |||
| arr[self.isna()] = False | |||
| return arr | |||
| elif op in {operator.ne, operator.lt, operator.gt}: | |||
| elif op == operator.ne: | |||
There was a problem hiding this comment.
Was not sure about it, but it does get hit through !=
There was a problem hiding this comment.
quickly scanning the code, it appears we mostly use is elsewhere
jreback
reviewed
Jun 13, 2022
pandas/tests/indexes/test_base.py
Outdated
| @@ -1604,3 +1604,15 @@ def test_get_attributes_dict_deprecated(): | |||
| with tm.assert_produces_warning(DeprecationWarning): | |||
| attrs = idx._get_attributes_dict() | |||
| assert attrs == {"name": None} | |||
|
|
|||
|
|
|||
| def test_nan_comparison_same_object(): | |||
There was a problem hiding this comment.
can you test gt as well as lt; this doesn't affect le, ge right?
There was a problem hiding this comment.
Done and no, they are checked i a different if block
|
thanks @phofl |
|
@meeseeksdev backport 1.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 15, 2022
|
Could not push to auto-backport-of-pr-47326-on-1.4.x due to error, aborting. |
simonjayhawkins
pushed a commit
that referenced
this pull request
Jun 15, 2022
… Index object) (#47364) Backport PR #47326: REGR: Fix nan comparison for same Index object Co-authored-by: Patrick Hoefler <[email protected]>
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.