-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: cleanup of any_* test fixtures GH38017 #43047
TST: cleanup of any_* test fixtures GH38017 #43047
Conversation
pratyushsharan
commented
Aug 15, 2021
- closes TST: any_* fixtures are confusingly named #38017
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
Hello @pratyushsharan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-18 03:20:12 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok looks pretty good
- precommit is failing
- can you show the number of tests on master vs number of tests here (should be the same unless there is an error somewhere)
merge master & ping when green (as any PRs might affect this so can merge quickly after looks good).
…hub.com/pratyushsharan/pandas into issue-38017-fix-confusing-test-fixtures
Fixed.
I've checked the number of tests using |
thanks @pratyushsharan very nice! |