Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: cleanup of any_* test fixtures GH38017 #43047

Conversation

pratyushsharan
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented Aug 15, 2021

Hello @pratyushsharan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-18 03:20:12 UTC

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Aug 16, 2021
@simonjayhawkins simonjayhawkins added this to the 1.4 milestone Aug 16, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok looks pretty good

  • precommit is failing
  • can you show the number of tests on master vs number of tests here (should be the same unless there is an error somewhere)

merge master & ping when green (as any PRs might affect this so can merge quickly after looks good).

@pratyushsharan pratyushsharan requested a review from jreback August 18, 2021 17:09
@pratyushsharan
Copy link
Contributor Author

  • precommit is failing

Fixed.

  • can you show the number of tests on master vs number of tests here (should be the same unless there is an error somewhere)

I've checked the number of tests using pytest pandas --collect-only and both master and this branch have the same number of tests - 181359. The results on Azure pipelines also give the same result.
This branch: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=64499&view=ms.vss-test-web.build-test-results-tab
Master branch: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=64511&view=ms.vss-test-web.build-test-results-tab

@jreback jreback merged commit d0e20a0 into pandas-dev:master Aug 18, 2021
@jreback
Copy link
Contributor

jreback commented Aug 18, 2021

thanks @pratyushsharan very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: any_* fixtures are confusingly named
4 participants