TST: clean old sql tests #42835
Merged
TST: clean old sql tests #42835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangchenli
added
the
Testing
mroeschke
reviewed
Aug 6, 2021
| @pytest.mark.single | ||
| @pytest.mark.db | ||
| @pytest.mark.skip( | ||
| reason="gh-13611: there is no support for MySQL if SQLAlchemy is not installed" |
There was a problem hiding this comment.
Just curious, is is not possible for us to test MySQL with these test or are these covered in different tests?
There was a problem hiding this comment.
These are covered in different tests using sqlalchemy. My guess is many years ago pandas's SQL functions were implemented directly on top of SQL drivers like pymysql. And after refactoring using sqlalchemy, those old tests were skipped but not removed for some reason.
mroeschke
approved these changes
Aug 6, 2021
jreback
reviewed
Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove skipped mysql tests, simplify old sqlite tests
a small step towards #40686