Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Deprecate non-keyword arguments in read_table #41485 #41717

Merged
merged 3 commits into from
May 31, 2021
Merged

CLN: Deprecate non-keyword arguments in read_table #41485 #41717

merged 3 commits into from
May 31, 2021

Conversation

tegardp
Copy link
Contributor

@tegardp tegardp commented May 29, 2021 •
edited by jreback
Loading

@pep8speaks
Copy link

pep8speaks commented May 29, 2021 •
edited
Loading

Hello @tegardp! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-29 21:40:33 UTC

MarcoGorelli
MarcoGorelli requested changes May 29, 2021
View reviewed changes
pandas/tests/io/parser/common/test_common_basic.py Outdated

def test_read_table_posargs_deprecation(all_parsers):
# https://github.com/pandas-dev/pandas/issues/41485
f = StringIO("a\tb\n1\t2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you not use a single-letter variable name? other than that, looks good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I pushed it to concat 's PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you push it here instead and keep the two PRs separate?

MarcoGorelli
MarcoGorelli requested changes May 29, 2021
View reviewed changes
pandas/tests/io/parser/common/test_common_basic.py Outdated

def test_read_table_posargs_deprecation(all_parsers):
# https://github.com/pandas-dev/pandas/issues/41485
f = StringIO("a\tb\n1\t2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you push it here instead and keep the two PRs separate?

datapythonista
datapythonista approved these changes May 29, 2021
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs #41665 to be merged to be green, but the PR lgtm

@datapythonista datapythonista added Clean IO CSV read_csv, to_csv labels May 29, 2021
@lithomas1 lithomas1 added Deprecate Functionality to remove in pandas and removed Clean labels May 29, 2021
@lithomas1 lithomas1 added this to the 1.3 milestone May 29, 2021
MarcoGorelli
MarcoGorelli approved these changes May 30, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good to me

@jreback jreback mentioned this pull request May 31, 2021
Closed
@jreback jreback merged commit bc9b470 into pandas-dev:master May 31, 2021
@jreback
Copy link
Contributor

jreback commented May 31, 2021

thanks @tegardp

TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@tegardp @TLouf
CLN: Deprecate non-keyword arguments in read_table pandas-dev#41485 (p…
8d197d3 
…andas-dev#41717)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@tegardp @JulianWgs
CLN: Deprecate non-keyword arguments in read_table pandas-dev#41485 (p…
9818e1a 
…andas-dev#41717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas IO CSV read_csv, to_csv
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@tegardp @pep8speaks @jreback @datapythonista @MarcoGorelli @lithomas1