Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate passing default arguments as positional in reset_index #41496

Merged
merged 5 commits into from
May 26, 2021
Merged

Deprecate passing default arguments as positional in reset_index #41496

merged 5 commits into from
May 26, 2021

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented May 15, 2021 •
edited
Loading

@jbrockmendel
Copy link
Member

looks like theres a usage in the docs that needs updating

@simonjayhawkins simonjayhawkins added the Deprecate Functionality to remove in pandas label May 17, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 17, 2021
@simonjayhawkins
Copy link
Member

this does not close #41485

jorisvandenbossche
jorisvandenbossche requested changes May 17, 2021
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed to also deprecate level? The first argument seems obvious that it is about the index level? We could also allow the first one to be positional as in other PRs?

@jorisvandenbossche jorisvandenbossche changed the title deprecate default arguments as positional in reset_index Deprecate passing default arguments as positional in reset_index May 17, 2021
@MarcoGorelli MarcoGorelli force-pushed the deprecate-nonkeyword-args-reset_index branch from ede455f to 10fbed6 Compare May 17, 2021 20:59
@MarcoGorelli MarcoGorelli marked this pull request as draft May 18, 2021 08:14
@MarcoGorelli MarcoGorelli marked this pull request as ready for review May 19, 2021 19:56
@MarcoGorelli MarcoGorelli force-pushed the deprecate-nonkeyword-args-reset_index branch from 63285bf to 657f9ce Compare May 23, 2021 17:17
@jreback jreback merged commit 45ad3ef into pandas-dev:master May 26, 2021
@jreback jreback mentioned this pull request May 26, 2021
Closed
@MarcoGorelli MarcoGorelli deleted the deprecate-nonkeyword-args-reset_index branch May 26, 2021 08:07
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@MarcoGorelli @TLouf
Deprecate passing default arguments as positional in reset_index (pan…
7176e62 
…das-dev#41496)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@MarcoGorelli @JulianWgs
Deprecate passing default arguments as positional in reset_index (pan…
d5c64a8 
…das-dev#41496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche requested changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@MarcoGorelli @jbrockmendel @simonjayhawkins @jorisvandenbossche @jreback