TST: Add tests for old issues #41482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
May 15, 2021
mroeschke
commented
- closes BUG: duplicate indexing on non-integer index with positional indexers failing in py3 #13427
- closes BUG: Index set operations issues #13432
- closes Partial indexing with a list and hierarchical index #13501
- closes frame and columns can get out of sync #13569
- closes ERR: set errno in read_csv #13872
- closes BUG: Columns used in sum on 1 row dataframe depend on values instead of dtype #13912
- closes Column reappears after drop() when working on a reference of that column #13934
- closes BUG: unstack doesn't preserve categorical dtype #14018
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
mroeschke
added
the
Testing
| def test_drop_inplace_no_leftover_column_reference(self): | ||
| # GH 13934 | ||
| df = DataFrame() | ||
| df["a"] = [1, 2, 3] |
There was a problem hiding this comment.
is it important that this is set here instead of being part of the constructor?
| def test_frame_mixed_numeric_object_with_timestamp(ts_value): | ||
| # GH 13912 | ||
| df = DataFrame({"a": [1], "b": [1.1], "c": ["foo"], "d": [ts_value]}) | ||
| result = df.sum() |
There was a problem hiding this comment.
test_frame_reductions i think
| df = DataFrame({"cat": pd.Categorical(["a", "b"])}, index=idx) | ||
| result = df.unstack() | ||
| expected = DataFrame( | ||
| [ |
There was a problem hiding this comment.
can you pass this as a dict or use from_arrays? IIRC the constructor is wonky specifically if the first listlike is a categorical
| frame.index.names = ["key1", "key2"] | ||
| frame.columns.names = ["state", "color"] | ||
| with pytest.raises(KeyError, match="\\[2\\] not in index"): | ||
| frame.loc[["b", 2], "Colorado"] |
There was a problem hiding this comment.
this is bc the user passed a list instead of a tuple?
There was a problem hiding this comment.
Correct, as a tuple I think this should correctly select
In [2]: frame
Out[2]:
state Ohio Colorado
color Green Red Green
key1 key2
a 1 0 1 2
2 3 4 5
b 1 6 7 8
2 9 10 11
In [3]: frame.loc[('b', 2), 'Colorado']
Out[3]:
color
Green 11
Name: (b, 2), dtype: int64
jreback
approved these changes
May 17, 2021
|
thanks @mroeschke |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.