TST: Add regression tests for old issues #41389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
May 9, 2021
mroeschke
commented
- closes Regression in casting Series to DataFrame with .name='foo' and columns=['bar'] #7893
- closes BUG: loc.__setitem__ over MultiIndex with slice key and step != 1 does strange things #8856
- closes BUG: concat of all-nan with empty frame produces object dtype #9188
- closes BUG: NaN level values in stack() and unstack() #9406
- closes Aligning on multi-index with swapped levels gives unclear error message #9952
- closes Dataframe Where Dataframe == False Returns Dataframe with Floats #10336
- closes Indexing a multi-index does not respect order of list indexer #10710
- closes BUG: reset_index of level on a MultiIndex with NaT converts to np.nan #11479
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
simonjayhawkins
approved these changes
May 9, 2021
jbrockmendel
reviewed
May 9, 2021
| # GH 7893 | ||
| result = DataFrame(Series(1, name="foo"), columns=["bar"]) | ||
| expected = DataFrame(columns=["bar"]) | ||
| tm.assert_frame_equal(result, expected) |
There was a problem hiding this comment.
this strikes me as weird. if the series's name was "bar", then result would have length 1 instead of 0.
There was a problem hiding this comment.
Yeah I'm not sure; just seems it was the preferred behavior from #7893 (comment)
There was a problem hiding this comment.
cc @jreback as you had mentioned that this behavior was expected
There was a problem hiding this comment.
yeah we should prob deprecate this but its the current behavior
jreback
approved these changes
May 10, 2021
| # GH 7893 | ||
| result = DataFrame(Series(1, name="foo"), columns=["bar"]) | ||
| expected = DataFrame(columns=["bar"]) | ||
| tm.assert_frame_equal(result, expected) |
There was a problem hiding this comment.
yeah we should prob deprecate this but its the current behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.