[ArrayManager] ENH: ArrayManager.convert without block fallback #40196
Conversation
jorisvandenbossche
added
Refactor
| numeric=numeric, | ||
| timedelta=timedelta, | ||
| ) | ||
| def _convert(arr): |
There was a problem hiding this comment.
What's not pretty about it? The inline function?
There was a problem hiding this comment.
soft_convert_objects can just do this directly right? (or the copy keyword is not functioning)
There was a problem hiding this comment.
Currently soft_convert_objects assumes the input is object dtype, and doesn't do such checking. I assume the check could be moved into soft_convert_objects as well (although eg for Block, which has an ObjectBlock, it knows it is ndarray[object], and such an additional check would be unnecessary)
There was a problem hiding this comment.
BTW soft_convert_objects is only used for ObjectBlock.convert ATM, so no real harm in making it handle non-object with these extra two lines (though to get effective simplification in the BM code might need to tweak copy kwarg behavior)
There was a problem hiding this comment.
ok if would revisit / consolidate logic at some point here.
xref #39146