TST: Replace pytest.xfail #38929
Merged
TST: Replace pytest.xfail #38929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 3, 2021
pandas/tests/indexes/test_common.py
Outdated
| @@ -388,7 +388,7 @@ def test_asi8_deprecation(self, index): | |||
| @pytest.mark.parametrize("na_position", [None, "middle"]) | |||
| def test_sort_values_invalid_na_position(index_with_missing, na_position): | |||
| if isinstance(index_with_missing, (CategoricalIndex, MultiIndex)): | |||
| pytest.xfail("missing value sorting order not defined for index type") | |||
| pytest.skip("missing value sorting order not defined for index type") | |||
There was a problem hiding this comment.
hmm i would leave these as xfail and add_marker here. e.g. these are a missing api that we should eventually fix.
There was a problem hiding this comment.
For MultiIndex we get NotImplementedError; this should certainly be left as xfail. However for CategoricalIndex the computation is successful and sometimes the order is "correct" and sometimes not. I think this should skip instead.
There was a problem hiding this comment.
Sorry, my remark is about test_sort_values_with_missing, the test immediately below this one.
jreback
approved these changes
Jan 4, 2021
|
thanks @rhshadrach |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffPart of #38902.