Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary use of Appender #37703

Merged
merged 1 commit into from
Nov 11, 2020
Merged

remove unnecessary use of Appender #37703

merged 1 commit into from
Nov 11, 2020

Conversation

smartvinnetou
Copy link
Contributor

@smartvinnetou smartvinnetou commented Nov 8, 2020 •
edited
Loading

@smartvinnetou smartvinnetou force-pushed the CLN-31942/replace-appender-with-doc-8 branch from 032edf4 to 3657dd9 Compare November 9, 2020 10:10
WillAyd
WillAyd approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - renders OK I take it? If so if you take out of draft status can merge

@WillAyd WillAyd added the Docs label Nov 10, 2020
@WillAyd WillAyd added this to the 1.2 milestone Nov 10, 2020
@smartvinnetou smartvinnetou marked this pull request as ready for review November 11, 2020 18:56
@charlesdong1991 charlesdong1991 merged commit 44406a6 into pandas-dev:master Nov 11, 2020
@charlesdong1991
Copy link
Member

nice! @smartvinnetou

This was referenced Nov 11, 2020
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@smartvinnetou @charlesdong1991 @WillAyd @davidmspeechmatics