Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: split up tests/plotting/test_frame.py into subdir & modules #34769 #37655

Merged
merged 162 commits into from
Nov 13, 2020
Merged

TST: split up tests/plotting/test_frame.py into subdir & modules #34769 #37655

merged 162 commits into from
Nov 13, 2020

Conversation

Mikhaylov-yv
Copy link
Contributor

@Mikhaylov-yv Mikhaylov-yv commented Nov 5, 2020

Created instead of #37538

I moved the file to a new directory.
What is the best structure for this folder?

before_test_ploting_frame
after_test_ploting_frame

of test_frame.py
to test_frame_color.py
of test_frame.py
to test_frame_groupby.py and test_frame_subplots.py
# Conflicts:
#	pandas/tests/plotting/frame/test_frame.py
of test_frame.py
to test_frame_subplots.py
of test_frame.py
to test_frame_groupby.py, test_frame_subplots.py, test_frame_color.py
@jreback jreback added Testing pandas testing functions or related to the test suite Visualization plotting labels Nov 6, 2020
@jreback jreback added this to the 1.2 milestone Nov 6, 2020
@jreback
Copy link
Contributor

jreback commented Nov 6, 2020

in pre-commit:

pandas/tests/plotting/frame/test_frame_groupby.py:7:1: F401 'pandas as pd' imported but unused

also merge master and ping on green.

@Mikhaylov-yv
Copy link
Contributor Author

I am very sorry. I don’t understand what to do next?

@jbrockmendel
Copy link
Member

I am very sorry. I don’t understand what to do next?

run git pull upstream master to merge master, then in the new files use from pandas import foo instead of pd.foo

@Mikhaylov-yv
Copy link
Contributor Author

Mikhaylov-yv commented Nov 8, 2020

Thanks @jbrockmendel. After that, I get a message like this:
image
Am I doing the right thing?

@Mikhaylov-yv
Copy link
Contributor Author

I hope I took into account all my mistakes

@Mikhaylov-yv
Copy link
Contributor Author

The errors don't seem to be relevant to my pull request. I'm wrong?

@jbrockmendel
Copy link
Member

The errors don't seem to be relevant to my pull request. I'm wrong?

You are not wrong. This is affecting all the builds, you can ignore this failure for now.

@Mikhaylov-yv
Copy link
Contributor Author

Thanks @jbrockmendel Does this mean the job is ready? or do you need to do something else?

@jbrockmendel
Copy link
Member

@Mikhaylov-yv is this pretty much cut/paste? if so, can you merge master and ping on green

@Mikhaylov-yv
Copy link
Contributor Author

@jbrockmendel Yes it is. the number of tests is the same as the master.
Now I'm going to merge

@jbrockmendel
Copy link
Member

LGTM cc @jreback

@jreback jreback merged commit 096f6be into pandas-dev:master Nov 13, 2020
@jreback
Copy link
Contributor

jreback commented Nov 13, 2020

thanks @Mikhaylov-yv

@Mikhaylov-yv
Copy link
Contributor Author

@jreback @jbrockmendel Thank you very much for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: split up tests/plotting/test_frame.py into subdir & modules