Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: catch FutureWarnings from Index.__and__ deprecation #37587

Merged
merged 1 commit into from
Nov 2, 2020
Merged

TST: catch FutureWarnings from Index.__and__ deprecation #37587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pandas/tests/series/test_arithmetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,17 +731,23 @@ def test_series_ops_name_retention(flex, box, names, all_binary_operators):
left = Series(range(10), name=names[0])
right = Series(range(10), name=names[1])

name = op.__name__.strip("_")
is_logical = name in ["and", "rand", "xor", "rxor", "or", "ror"]
is_rlogical = is_logical and name.startswith("r")

right = box(right)
if flex:
name = op.__name__.strip("_")
if name in ["and", "rand", "xor", "rxor", "or", "ror"]:
if is_logical:
# Series doesn't have these as flex methods
return
result = getattr(left, name)(right)
else:
result = op(left, right)
# GH#37374 logical ops behaving as set ops deprecated
warn = FutureWarning if is_rlogical and box is Index else None
with tm.assert_produces_warning(warn, check_stacklevel=False):
result = op(left, right)

if box is pd.Index and op.__name__.strip("_") in ["rxor", "ror", "rand"]:
if box is pd.Index and is_rlogical:
# Index treats these as set operators, so does not defer
assert isinstance(result, pd.Index)
return
Expand Down