-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGR: fix groupby std() with nullable dtypes #37433
Merged
jreback
merged 1 commit into
pandas-dev:master
from
jorisvandenbossche:fix-groupby-std-nullable
Oct 27, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -277,3 +277,38 @@ def test_read_only_buffer_source_agg(agg): | |
expected = df.copy().groupby(["species"]).agg({"sepal_length": agg}) | ||
|
||
tm.assert_equal(result, expected) | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"op_name", | ||
[ | ||
"count", | ||
"sum", | ||
"std", | ||
"var", | ||
"sem", | ||
"mean", | ||
"median", | ||
"prod", | ||
"min", | ||
"max", | ||
], | ||
) | ||
def test_cython_agg_nullable_int(op_name): | ||
# ensure that the cython-based aggregations don't fail for nullable dtype | ||
# (eg https://github.com/pandas-dev/pandas/issues/37415) | ||
df = DataFrame( | ||
{ | ||
"A": ["A", "B"] * 5, | ||
"B": pd.array([1, 2, 3, 4, 5, 6, 7, 8, 9, pd.NA], dtype="Int64"), | ||
} | ||
) | ||
result = getattr(df.groupby("A")["B"], op_name)() | ||
df2 = df.assign(B=df["B"].astype("float64")) | ||
expected = getattr(df2.groupby("A")["B"], op_name)() | ||
|
||
if op_name != "count": | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah also an issue to fix this up (I think we have another issue about this) as this is slightly tricky, e.g. are we returning a nullable for the count itself (I don't know if we ever decided that) |
||
# the result is not yet consistently using Int64/Float64 dtype, | ||
# so for now just checking the values by casting to float | ||
result = result.astype("float64") | ||
tm.assert_series_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use all_numeric_reductions fixture (although slightly different) doesn't include
sem
orcount
but does includekurt
andskew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kurt
is not implemented for groupby, it seems. I mainly copied this from another test in this file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for now I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah can you create an issue for folks to replace these with fixtures (good first)