CI: avoid file leaks in sas_xport tests #35693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Aug 13, 2020
pandas/tests/io/sas/test_xport.py
Outdated
| @@ -127,7 +131,8 @@ def test2_binary(self): | |||
| data_csv = pd.read_csv(self.file02.replace(".xpt", ".csv")) | |||
| numeric_as_float(data_csv) | |||
|
|
|||
| data = read_sas(self.file02b, format="xport") | |||
| with open(self.file02, "rb") as fd: | |||
| data = read_sas(fd, format="xport") | |||
There was a problem hiding this comment.
why is this actually leaking?
There was a problem hiding this comment.
IIUC ATM we're passing an open file and the read_sas call closes it incorrectly, so its an anti-leak
There was a problem hiding this comment.
this doesn't make sense; there is a bug in the xport reader; paper it over here is not a great soln.
jreback
approved these changes
Aug 13, 2020
|
thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a contextmanager version of td.check_file_leaks so we can do more targeted versions of those checks for debugging