CLN: replaced Appender with doc #33633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartvinnetou
force-pushed
the
CLN-31942/replace-appender-with-doc-4
branch
4 times, most recently
from
4394157 to
1b624ea
Compare
smartvinnetou
changed the title
WillAyd
approved these changes
Jun 26, 2020
|
Can you fix merge conflicts? |
smartvinnetou
force-pushed
the
CLN-31942/replace-appender-with-doc-4
branch
from
1b624ea to
f8566fc
Compare
|
Can you fix up merge conflict again? If so can merge |
|
@smartvinnetou can you fix conflicts? |
|
Will do.
…On Thu, 10 Sep 2020, 20:04 William Ayd, ***@***.***> wrote:
@smartvinnetou <https://github.com/smartvinnetou> can you fix conflicts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33633 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOSDPMQR23NHNI3MBUUW6L3SFEPMHANCNFSM4MLNGF7A>
.
|
|
one more rebase pls |
smartvinnetou
force-pushed
the
CLN-31942/replace-appender-with-doc-4
branch
from
f1108b3 to
0e5dc6d
Compare
|
Hello @smartvinnetou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-13 19:38:05 UTC |
|
Rebase done. Still some glitches in the doctests. Will keep fixing. |
smartvinnetou
force-pushed
the
CLN-31942/replace-appender-with-doc-4
branch
from
51261af to
a27e3f5
Compare
|
thanks @smartvinnetou keep em coming |
5 tasks
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff