-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN 31942/replace appender with doc 3 #33277
CLN 31942/replace appender with doc 3 #33277
Conversation
e0209f5
to
f6b3953
Compare
Hello @smartvinnetou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-14 20:34:47 UTC |
4e7dded
to
062a406
Compare
2591055
to
f5409be
Compare
cfc1a63
to
23bb2aa
Compare
2f92f60
to
10cb001
Compare
Can someone help with reviewing and merging this PR? |
1330020
to
f15188e
Compare
40ae8b9
to
f2bd1a2
Compare
Looks like some merge conflicts in - can you fix that up? |
f2bd1a2
to
164a63d
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smartvinnetou for future reference would be nice if you can make smaller PRs. Something with this many changes is much harder to review at once, so typically better to have multiple PRs with smaller changes.
That said this lgtm - @datapythonista care to look?
@WillAyd I appreciate that. That's why I stopped making more changes. I started other branches but soon found that there was a non trivial overhead on maintaining them and keeping them current. I hit a pause button until PRs start to be merged. |
@smartvinnetou can you please resolve the conflicts? As said, smaller PRs are faster to review, get merged faster, and conflicts are less likely. |
164a63d
to
42ebde7
Compare
c5b7133
to
69f28b5
Compare
Conflict resolved.
|
Thanks @smartvinnetou, very nice clean up. Once the development documentation is updated, can you please have a quick look at the updated pages, and see if everything is rendering as expected. Thanks! |
@datapythonista, where do I find this documentation? |
…Series/DataFrame methods (pandas-dev#33277)
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Appender
decorator withdoc