-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced one occurrence of Appender
by doc
decorator
#32787
replaced one occurrence of Appender
by doc
decorator
#32787
Conversation
Can you post a screenshot of the built docs to be sure? Otherwise lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @smartvinnetou. Good work here. There are couple of clean ups that would be great if you can implement in this same PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just one comment.
Following these instructions https://pandas.pydata.org/docs/development/contributing.html#updating-a-pandas-docstring I get the following error:
Lot more similar errors follow. I am on Windows 10 Home edition. |
Thanks for the work on this @smartvinnetou I think it's known that the documentation has some problems in Windows. We wanted to fix them and build the docs on Windows in the CI, but that didn't happen. Feel free to have a look, but as far as it works in the CI we can move forward. |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Appender
in pandas/core/generic.py withdoc